On Tue, Jul 22, 2008 at 04:53:19PM +0100, Daniel P. Berrange wrote:
On Tue, Jul 22, 2008 at 11:42:03AM -0400, Cole Robinson wrote: [..snip..]
2) If a cpuset isn't specified, def->cpumask is null. However qemudInitCpus from qemu_driver.c doesn't know how to handle this, causing libvirtd to crash. This function is also using QEMUD_CPUMASK_LEN which I think should be replaced with VIR_DOMAIN_CPUMASK_LEN. I tried the obvious fix of just skipping the dependent code if cpumask is null, but there still seemed to be problems and I didn't dig much deeper.
I'm surprised that doesn't work - we should be able to just skip the bit of code within the HAVE_SCHED_GETAFFINITY conditional, and go straight to the part when it issues the 'cont' command to the monitor to start execution. What you suggested works here. -- Guido