Re: [libvirt] [PATCH 2/9] virt-admin: Introduce first working skeleton

On 13.10.2015 15:38, Erik Skultety wrote: > This patch introduces virt-admin client which is based on virsh client, > but had to reimplement several methods to meet virt-admin specific needs > or remove unnecessary virsh specific logic. > --- > .gitignore | 1 + > daemon/libvirtd.c | 3 +- > include/libvirt/libvirt-admin.h | 1 + > po/POTFILES.in | 1 + > src/libvirt-admin.c | 31 +++ > src/libvirt_admin_public.syms | 1 + > tools/Makefile.am | 28 +- > tools/virt-admin.c | 604 ++++++++++++++++++++++++++++++++++++++++ > tools/virt-admin.h | 71 +++++ > 9 files changed, 737 insertions(+), 4 deletions(-) > create mode 100644 tools/virt-admin.c > create mode 100644 tools/virt-admin.h > > diff --git a/.gitignore b/.gitignore > index 2d52a8f..a776947 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -176,6 +176,7 @@ > /tools/virt-login-shell > /tools/virsh > /tools/virsh-*-edit.c > +/tools/virt-admin > /tools/virt-*-validate > /tools/virt-sanlock-cleanup > /tools/wireshark/src/plugin.c > diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c > index 250094b..8734f93 100644 > --- a/daemon/libvirtd.c > +++ b/daemon/libvirtd.c > @@ -522,8 +522,7 @@ daemonSetupNetworking(virNetServerPtr srv, > virNetServerAddService(srv, svcRO, NULL) < 0) > goto cleanup; > > - /* Temporarily disabled */ > - if (sock_path_adm && false) { > + if (sock_path_adm) {