On 04/11/2012 08:41 AM, Eric Blake wrote:
On 04/11/2012 03:17 AM, Michal Privoznik wrote:
If dynamic_ownership is off and we are creating a file on NFS we force chown. This will fail as chown/chmod are not supported on NFS. However, with no dynamic_ownership we are not required to do any chown. --- src/qemu/qemu_driver.c | 10 ++++++++-- 1 files changed, 8 insertions(+), 2 deletions(-)
ACK.
My ACK may be premature. I think we need to worry about multiple scenarios - it is true that root-squash NFS won't allow a chown, but not all NFS are root-squash, so this may be breaking something. I'll let Laine chime in with a review, since he has historically had experience with testing multiple NFS setups. -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org