On Mon, Mar 31, 2008 at 08:49:12AM -0400, Daniel Veillard wrote:
On Mon, Mar 31, 2008 at 08:12:19AM -0400, Daniel Veillard wrote:
On Mon, Mar 31, 2008 at 01:02:49PM +0100, Daniel P. Berrange wrote:
We should at the very least NULL-ify the dom/net fields in the Error object associated with the Connection when we free the Domain/Network object.
agreed, very simple test but avoids dandling pointers.
My patch for this. it's a bit more complex because we also keep a global variable for the last variable, and that needed to be exported to the hash module, it's still rather simple,
Yes, that's pretty much what I was thinking we should do - ACK from me. Dan. -- |: Red Hat, Engineering, Boston -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|