Re: [libvirt] [PATCH 1/2] cpu-max: Implement cpu-max attribute into capabilities XML output
On Wed, Apr 17, 2013 at 03:21:04AM +0200, Michal Novotny wrote:
Implement the cpu-max attribute into virConnectGetCapabilities() API
output to allow caller to check maximum number of CPUs to be set for
specified machine type.
Signed-off-by: Michal Novotny <minovotn(a)redhat.com>
---
docs/schemas/capability.rng | 5 +++++
src/conf/capabilities.c | 4 ++++
src/conf/capabilities.h | 1 +
src/qemu/qemu_capabilities.c | 40 +++++++++++++++++++++++++++++++++++++++-
src/qemu/qemu_capabilities.h | 3 ++-
src/qemu/qemu_monitor.h | 1 +
src/qemu/qemu_monitor_json.c | 7 +++++++
7 files changed, 59 insertions(+), 2 deletions(-)
We've previously said that we're not going to expand the information
shown against individual machines in the capabilities, because this
is not really scalable to cover all the capabilities you'd wish to
show per machine. We'd end up with capabilties XML many MB in size.
So I'm not really in favour of this patch.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|