Re: [libvirt] [PATCH 1/8] Define a QEMU specific API to attach to a running QEMU process

On 07/04/2011 04:28 AM, Daniel P. Berrange wrote:

Introduce a new API in libvirt-qemu.so

virDomainPtr virDomainQemuAttach(virConnectPtr domain, unsigned long long pid,

We already assert elsewhere in our code base that pid_t will always fit in int. For example, see _virDomainObj in domain_conf.h. Passing a ull here seems like it might be overkill. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org