Re: [PATCH 0/2] libxl: Support custom EFI firmware path
On 3/10/23 06:58, Michal Prívozník wrote:
On 2/13/23 22:45, Jim Fehlig wrote:
> libxl added support for specifying custom firmware paths long ago. This series
> adds support to the libxl driver and the XML to xl.cfg config converter.
>
> Jim Fehlig (2):
> libxl: Support specifying a custom firmware path
> libxl: Add support for custom firmware path in config converter
>
> src/libxl/libxl_conf.c | 14 ++--
> src/libxl/xen_xl.c | 19 +++--
> tests/libxlxml2domconfigdata/efi-hvm.json | 91 +++++++++++++++++++++++
> tests/libxlxml2domconfigdata/efi-hvm.xml | 36 +++++++++
> tests/libxlxml2domconfigtest.c | 1 +
> tests/xlconfigdata/test-fullvirt-ovmf.cfg | 1 +
> tests/xlconfigdata/test-fullvirt-ovmf.xml | 2 +-
> 7 files changed, 150 insertions(+), 14 deletions(-)
> create mode 100644 tests/libxlxml2domconfigdata/efi-hvm.json
> create mode 100644 tests/libxlxml2domconfigdata/efi-hvm.xml
>
Ooops, this has slipped through the cracks even though I had it marked
for review. Sorry.
No worries. Thanks a lot for taking the time to review!
Reviewed-by: Michal Privoznik <mprivozn(a)redhat.com>
BTW: what's your view on bumping minimal XEN version from 4.9 to at
least 4.10 (or even something newer)? That way we could drop some code
(at least).
We could drop a fair bit of code by bumping the minimum version to 4.13. That
would allow us to unconditionally set LIBXL_API_VERSION to 0x041300 and drop
support for the old 0x040500. We got stuck there since Xen didn't advertise
support for 0x040700 and 0x040800 until commit c3999835df2, which was included
in 4.13 - opps! According to repology
Debian 11: 4.14.x
Fedora 37: 4.16.x
openSUSE Leap15.4/SLE15 SP4: 4.16.x
Ubuntu 22.10: 4.16.x
Maybe bumping the minimum version to 4.13 is a viable proposition?
Regards,
Jim