On Tue, 2021-06-15 at 10:08 +0200, Martin Kletzander wrote:
On Mon, Jun 14, 2021 at 09:12:57PM +0800, Luke Yue wrote:
Signed-off-by: Luke Yue <lukedyue@gmail.com> --- src/test/test_driver.c | 41 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 41 insertions(+)
This patch looks fine, but it would be good to have tests for it also. The good thing is that thanks to the fact that this is a test driver API the check can be done using just virsh, no need to write tests and mock syscalls. The previous patches added at least some checks, because it was already in some other test codepath, but this (and later ones as well) are going to need to have some new ones added.
Thanks for the review! It seems that there is no command in virsh uses virDomainGetSecurityLabelList, should we add one? Or is there any other testing methods? Thanks, Luke