Re: [libvirt] [libvirt-php][PATCH 0/3] Couple of small fixes
On Tue, Apr 19, 2016 at 9:46 AM, Michal Privoznik <mprivozn(a)redhat.com> wrote:
While playing with our php bindings I've noticed couple of
memory
leaks mostly. And one bug in our examples.
Michal Privoznik (3):
examples: Check properly if connected
Fix some leaks related to get_string_from_xpath
Revisit some VIRT_RETURN_STRING
examples/index.php | 4 +-
src/libvirt-php.c | 121 ++++++++++++++++++++++++++++++-----------------------
2 files changed, 72 insertions(+), 53 deletions(-)
--
2.7.3
For the patch set, I couldn't get the first one through the ML (for
some reason, the ML never sent it to my inbox). The other two,
however, made it and I've tested them. They applied cleanly, and
libvirt-php built and ran cleanly on PHP5 and PHP7 on CentOS 7 and
PHP7 on Ubuntu 16.04.
Reading the first patch through the list archive, I manually applied
and tested. Everything seems fine with it.
For the patch series as a whole, I give it a thumbs up! :)
--
真実はいつも一つ！/ Always, there's only one truth!