Re: [libvirt] [PATCH v3 2/5] libxl: add support for PVH

On 10/2/18 5:02 PM, Marek Marczykowski-Górecki wrote: > On Tue, Oct 02, 2018 at 04:50:02PM -0600, Jim Fehlig wrote: > > My idea to add this variable for clarity now seems diluted by the need for > > the extra ifdef's :-/. Your original approach would avoid them. > > This #ifdef is only to mute compiler warning (variable set but unused). > If you have a better idea for that, I'd very much like to drop #ifdef > here. Given the ifdef trickery needed with the extra variable, I think the better idea is your original idea :-) i == nr_guest_archs - 1