On Wed, Aug 20, 2014 at 12:47:28PM +0200, Ján Tomko wrote:
On 08/19/2014 03:10 PM, Martin Kletzander wrote:
> Commits 0728d472 and 399394ab added suuport for
> VIR_DOMAIN_BLKIO_DEVICE_*, but all the values were parsed with
> underflow being allowed. Since there is no point in that, it should
> be fixed. Unfortunately the code is duplicated (apart from passing
> device/value pairs as a string :-/), so it needs to be fixed twice.
Any suggestions for naming the file this could be split into are welcome:
https://www.redhat.com/archives/libvir-list/2014-June/msg00789.html
Like, um..., domain_conf.c? Of any new file in _conf that'd be
separated. How about putting all blkio- (and conf-) related stuff int
blkio_conf.[hc]?
>
> This "series" fixes
https://bugzilla.redhat.com/show_bug.cgi?id=1131306
>
> Martin Kletzander (2):
> lxc: forbid negative blkio values
> qemu: forbid negative blkio values
>
> src/lxc/lxc_driver.c | 8 ++++----
> src/qemu/qemu_driver.c | 10 +++++-----
> 2 files changed, 9 insertions(+), 9 deletions(-)
>
ACK series
Thanks, pushed now.
Martin