Re: [PATCH 1/3] tests: Add TPM coverage to default-models tests
On Mon, May 27, 2024 at 19:31:34 +0200, Andrea Bolognani wrote:
We have a non-trivial amount of architecture-specific logic
dealing with TPM, so it's good to have coverage for it.
Note that TPM supports seems to be currently missing from s390x
and loongarch64 QEMU builds. I'm not entirely sure whether
I presume you mean that TPM support was not built into the QEMU builds
used to capture the capability dumps, right?
there's a good reason for that or it's simply an oversight,
but
either way we have to skip them for now.
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
...aarch64-virt-default-models.aarch64-latest.abi-update.args | 3 +++
.../aarch64-virt-default-models.aarch64-latest.abi-update.xml | 3 +++
.../aarch64-virt-default-models.aarch64-latest.args | 3 +++
.../aarch64-virt-default-models.aarch64-latest.xml | 3 +++
tests/qemuxmlconfdata/aarch64-virt-default-models.xml | 3 +++
tests/qemuxmlconfdata/loongarch64-virt-default-models.xml | 1 +
.../ppc64-pseries-default-models.ppc64-latest.abi-update.args | 3 +++
.../ppc64-pseries-default-models.ppc64-latest.abi-update.xml | 4 ++++
.../ppc64-pseries-default-models.ppc64-latest.args | 3 +++
.../ppc64-pseries-default-models.ppc64-latest.xml | 4 ++++
tests/qemuxmlconfdata/ppc64-pseries-default-models.xml | 3 +++
...riscv64-virt-default-models.riscv64-latest.abi-update.args | 3 +++
.../riscv64-virt-default-models.riscv64-latest.abi-update.xml | 3 +++
.../riscv64-virt-default-models.riscv64-latest.args | 3 +++
.../riscv64-virt-default-models.riscv64-latest.xml | 3 +++
tests/qemuxmlconfdata/riscv64-virt-default-models.xml | 3 +++
tests/qemuxmlconfdata/s390x-ccw-default-models.xml | 1 +
.../x86_64-pc-default-models.x86_64-latest.abi-update.args | 3 +++
.../x86_64-pc-default-models.x86_64-latest.abi-update.xml | 3 +++
.../x86_64-pc-default-models.x86_64-latest.args | 3 +++
.../x86_64-pc-default-models.x86_64-latest.xml | 3 +++
tests/qemuxmlconfdata/x86_64-pc-default-models.xml | 3 +++
.../x86_64-q35-default-models.x86_64-latest.abi-update.args | 3 +++
.../x86_64-q35-default-models.x86_64-latest.abi-update.xml | 3 +++
.../x86_64-q35-default-models.x86_64-latest.args | 3 +++
.../x86_64-q35-default-models.x86_64-latest.xml | 3 +++
tests/qemuxmlconfdata/x86_64-q35-default-models.xml | 3 +++
27 files changed, 79 insertions(+)
[...]
diff --git
a/tests/qemuxmlconfdata/loongarch64-virt-default-models.xml
b/tests/qemuxmlconfdata/loongarch64-virt-default-models.xml
index 109fb3b3ea..e59ebdeed4 100644
--- a/tests/qemuxmlconfdata/loongarch64-virt-default-models.xml
+++ b/tests/qemuxmlconfdata/loongarch64-virt-default-models.xml
@@ -14,6 +14,7 @@
<mac address='52:54:00:09:a4:37'/>
</interface>
<serial type='pty'/>
+ <!-- TPM support not currently built on loongarch64 -->
<video/>
<memballoon model='none'/>
[...]
diff --git a/tests/qemuxmlconfdata/s390x-ccw-default-models.xml
b/tests/qemuxmlconfdata/s390x-ccw-default-models.xml
index a196129628..dd97349e6f 100644
--- a/tests/qemuxmlconfdata/s390x-ccw-default-models.xml
+++ b/tests/qemuxmlconfdata/s390x-ccw-default-models.xml
@@ -14,6 +14,7 @@
<mac address='52:54:00:09:a4:37'/>
</interface>
<serial type='pty'/>
+ <!-- TPM support not currently built on s390x -->
Both the commit message and this comment isn't really clear whether TPM
is not supported by the platform itself or just was omitted when
building qemu which was used for the caps dump.
I think it will be even harder to understand this for anyone who finds
this comment later.
I suggest:
TPM was not compiled into the QEMU binary used for the capability
dump, but platform supports it
Or something similar more clear.
Reviewed-by: Peter Krempa <pkrempa(a)redhat.com>