Re: [libvirt] [PATCH v3 1/9] Implement public API for virDomainGetIOThreadsInfo

On Thu, Mar 05, 2015 at 07:45:51AM -0500, John Ferlan wrote: > >> + unsigned char *cpumap; /* CPU map for thread */ > >> + int cpumaplen; /* cpumap size */ > > > >> + size_t nresources; /* count of resources using IOThread */ > >> + char **resources; /* array of resources using IOThread */ > > > > "resources" is too vague. > > Suggestion? Is "devices" better? > > Today it's the disk source path, but I remember reading something where > an IOThread could be potentially used for something else (perhaps > network, but I cannot find the reference quickly). > I just worry that putting the path here could be a problem sometime in the future if the attribute gets extended (I think some of the Block* APIs had that problem). Perhaps Peter or Eric will voice their opinion.