Re: [libvirt] [PATCH 6/6] qemuProcessReconnectHelper: Don't create joinable thread
On Thu, Nov 14, 2013 at 10:51:16AM +0100, Michal Privoznik wrote:
In the qemuProcessReconnectHelper() a new thread that do all the
s/do/does/
interesting work is spawned. The rationale is to not block the
daemon
startup process in case of unresponsive qemu. However, the thread
handler is a local variable which gets lost once the control goes out of
scope. Hence, the thread gets leaked. We can avoid this if the thread
s/,// ???
isn't make joinable.
s/make/made/
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
---
src/qemu/qemu_process.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
ACK,
Martin
Attachments:
- signature.asc (application/pgp-signature — 836 bytes)