Re: [PATCH 2/4] docs: Add redirects configuration for gitlab pages

On Wed, Jan 10, 2024 at 02:30:23PM +0100, Peter Krempa wrote: > Adapt the configuration of redirects from the server hosting libvirt.org > > The redirect to the 'libvirt-console-proxy' Golang module is not adapted > as it doesn't exist on the current server. > > NOTES: > - The redirects are currently configured for hosting via the > 'gitlab.io/libvirt' URI. For hosting via custom domain it will need > to be rewritten to drop the '/libvirt' prefixes. > > - gitlab pages doesn't currently support redirects to outside content, > thus most of the redirects don't actually work: > > https://gitlab.com/gitlab-org/gitlab-pages/-/issues/601 > > - The redirects file is only installed in the webpage job but is not > actually distributed. > > - The validity of the redirects can be checked by visiting: > > https://libvirt.gitlab.io/_redirects > > Having them installed allows us to validate them before we'll be > switching to use gitlab pages completely. > > Signed-off-by: Peter Krempa <pkrempa(a)redhat.com&gt; > --- > .gitlab-ci.yml | 1 + > docs/.gitlab_redirects | 54 ++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 55 insertions(+) > create mode 100644 docs/.gitlab_redirects > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml > index 6c7d54c311..1ee945aa0a 100644 > --- a/.gitlab-ci.yml > +++ b/.gitlab-ci.yml > @@ -130,6 +130,7 @@ website_prebuilt_env_legacy: > after_script: > - test "$CI_JOB_STATUS" != "success" && exit 1; > - mv install/usr/share/doc/libvirt/html/ public > + - cp docs/.gitlab_redirects public/_redirects > artifacts: > expose_as: 'pages' > name: 'pages' > diff --git a/docs/.gitlab_redirects b/docs/.gitlab_redirects > new file mode 100644 > index 0000000000..26e64563ee > --- /dev/null > +++ b/docs/.gitlab_redirects > @@ -0,0 +1,54 @@ > +/libvirt/maven2/* https://download.libvirt.org/maven2/:splat 301 Maven has this unhelpful behaviour where by when you add libvirt.org as a maven repository host, it'll now consult libvirt.org for *all* Java JARs, not solely the libvirt JARs. For all of last week we were serving about 1 million hits a day for /maven, of which the libvirt JAR requests were about 0.5%, the rest were 404s ! This is why libvirt.org was painfully slow for most of last week. This was all made worse by us redirecting from libvirt.org to download.libvirt.org, needlessly doubling the number of requests had to serve. I changed the /maven2/* redirect to /maven2/org/libvirt/* which lets libvirt.org service an immediate 404, avoiding hitting download.libvirt.org, cutting our requests by 50%. Fortunately traffic has died down to more normal levels after the "back to work mass code recompile" spike has gone. Anyway lets do the same for this gitlab redirect to keep the bogus maven traffic for non-existent files off download.libvirt.org