Re: [libvirt] PATCH: Latest MinGW patches

On Thu, Sep 04, 2008 at 03:58:19PM +0200, Daniel Veillard wrote: > On Wed, Sep 03, 2008 at 05:47:30PM +0100, Daniel P. Berrange wrote: > > On Wed, Sep 03, 2008 at 01:35:27PM +0100, Daniel P. Berrange wrote: > > > I've got a MinGW build environment setup on Fedora 10 now, so just checked > > > out what the latest state of libvirt CVS is. > > > > > > With the attached patch, I can run configure with: > > --- autobuild.sh 28 Aug 2008 09:08:44 -0000 1.10 > > +++ autobuild.sh 3 Sep 2008 16:44:21 -0000 > > @@ -17,8 +17,6 @@ rm -rf coverage > > ./autogen.sh --prefix="$AUTOBUILD_INSTALL_ROOT" \ > > --enable-test-coverage \ > > --enable-compile-warnings=error \ > > - --with-openvz \ > > - --with-lxc \ > > --with-xen-proxy > > In general fine by me, but I'm a bit annoyed if we don't build OpenVZ > and LXC by default in the build setup. Maybe one could differenciate > the build for MingW or just sisable lxc and openvz from the C code > if we are on the linux platform. Or some configure.in foo to override > --with-openvz and --with-lxc if using a cross compiler. You turned on OpenVZ / LXC by default - hence I no longer need to have the explicit --with-lxc or --with-openvz for autobuild.