Hi Daniel, I am sending an updated patch with the following changes: (1) Removed code pertaining to storage pools as we do not do use it at present. (2) Rebased patch to latest libvirt master (could be a day old as I cannot do a git pull locally) (3) Updated docs/formatdomain.html.in (4) Modified code to securely pass secrets to libvirt. (5) Added test case for openflame with new argv and sample xml files. Please try to take a quick look at the patch to see if you approve of the changes. I tried using “git send-email”, but unfortunately: (a) Internal firewall blocks git communication to outside world. I was thinking of using a http based read-only repo, but I guess that would be a bit older code. Do you know of a http based git repo mirror that I can reliably use for "git pull” etc? (b) git send-email is not working for me. I am having trouble setting it up to forward emails via my official MS Exchange server account. Here’s the same output from the new test: 127) QEMU XML-2-ARGV disk-drive-network-rbd-no-colon ... Got expected error: 2016-06-10 00:39:27.543+0000: 607: error : qemuBuildNetworkDriveURI:859 : unsupported configuration: ':' not allowed in RBD source volume name 'poolname/imagename:rbd_cache=1:rbd_cache_size=67108864:rbd_cache_max_dirty =0' OK 128) QEMU XML-2-ARGV disk-drive-network-oflame ... OK 129) QEMU XML-2-ARGV disk-drive-no-boot ... OK Regards, Ashish On 6/8/16, 8:05 AM, "Daniel P. Berrange" <berrange@redhat.com> wrote:
On Wed, Jun 08, 2016 at 02:55:24PM +0000, Ashish Mittal wrote:
Thanks Daniel!
I also sent a path on top of libvirt master using "git send-email" as directed on libvirt.org. That patch is much more cleaner. (1) does not have storage pool changes since OpenFlame does not use storage pools (yet). (2) Uses the new encrypted secret passing as the others have done.
Ah, that sounds great.
Some of your suggestions would still be valid on top of the master patch. I will make those changes and resubmit.
Can you please confirm if you¹ve received the other patch on top of master? I will continue to make all future changes on top of master using git send-email directly, if you so suggest.
Hmm, I don't appear to have received that other patch and there is only this first patch visible in the mailing list archives
https://www.redhat.com/archives/libvir-list/2016-June/author.html
I guess its possible there's a delay in our mailman delivery, but worth checking you used the right git send-email config too, in case of typos/etc
Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|