
1 Mar
2007
1 Mar
'07
8:58 a.m.
Mark McLoughlin wrote:
Hi Rich,
On Wed, 2007-02-28 at 17:33 +0000, Richard W.M. Jones wrote:
+#define virConfNew() (_virConfNew())
I wouldn't bother doing this, it just adds confusion - e.g. it helps to know that the symbol is private from the calling site too, so just use _virConfNew() everywhere ...
Also suggest surrounding everything with:
#ifdef LIBVIRT_PRIVATE_API_DO_NOT_USE
in src/conf.h (even though it's not installed) so that people have no excuse if they use this ...
Thanks Mark. I'll put up a third version later (probably tomorrow in fact, I'm building & fixing computers today). Rich.