
26 Jul
2019
26 Jul
'19
1:59 p.m.
On Tue, 2019-07-23 at 17:02 +0100, Daniel P. Berrangé wrote:
+remote/libvirtd.conf: remote/libvirtd.conf.in + $(AM_V_GEN)sed \ + -e '/:: CUT ENABLE_IP ::/d' \ + -e '/:: END ::/d' \ + -e 's/:: DAEMON_NAME ::/libvirtd/' \ + < $^ > $@
Using $^ seems a bit weird considering that you have a single input... Any reason not to use $< here? I would also use @DAEMON_NAME@ instead of ":: DAEMON_NAME ::" since the former style is already used everywhere for simple value replacement in .in files. -- Andrea Bolognani / Red Hat / Virtualization