Re: [PATCH v2] conf: Move validation checks from virDomainDiskDefIotuneParse into domain_validate.c

On 4/9/22 11:38, Moteen Shah wrote: I recomend using 'git send-email' which does the right thing (as in not send the patch as an attachment). Quick glance at the patch though: since you are touching the error messages (moving them, not changing them), please do put them on one line, like this: + virReportError(VIR_ERR_XML_ERROR, "%s", + _("total and read/write bytes_sec cannot be set at the same time")); Error message are exempt from the 80 chars long line rule, so that they are easy to 'git grep'. Michal