Re: [libvirt] [RFC PATCH 5/5] docs: Port apibuild.py to Python 3
On Wed, 2018-03-14 at 09:59 +0000, Daniel P. Berrangé wrote:
On Tue, Mar 13, 2018 at 07:42:47PM +0100, Andrea Bolognani wrote:
> A lot of tweaks needed.
>
> The generated files are bit by bit identical to those produced
> before when the script is invoked using Python 2, but using
> Python 3 results in some errors being reported and the build
> step to be considered failed. The output files are mostly the
> same, except <summary>, <description> and <author> are missing
> in *-api.xml files and <chunks> are missing from *-refs.xml
> files.
FWIW, I would find these changes easier to review if instead of
converting one file per patch, it had one type of change per
patch. ie find the print_function in all files, then fix the
sorted() usage in all files, then iteritems(), etc.
That would probably make a bunch of patches mergeable right away,
thus paving the way for someone with better Python knowledge to
jump in and take care of the tricky compatibility issues without
having to worry about the trivial stuff.
I'll work on it.
--
Andrea Bolognani / Red Hat / Virtualization