Re: [libvirt] [PATCH v2 3/9] test: Wire up managed save APIs
On 08/30/2013 10:03 AM, Cole Robinson wrote:
Also add a <test:hasmanagedsave> element to set this data when
starting
the connection.
---
src/test/test_driver.c | 129 ++++++++++++++++++++++++++++++++++++++++++++++++-
tests/virshtest.c | 2 +-
2 files changed, 129 insertions(+), 2 deletions(-)
Cool. Same problem as in patch 2 - managedsave makes sense only for a
shutoff persistent domain...
+ tmp = virXPathBoolean("boolean(./test:hasmanagedsave)", ctxt);
+ if (tmp == -1) {
+ virReportError(VIR_ERR_XML_ERROR, "%s", _("invalid
hasmanagedsave"));
+ goto error;
+ }
+ nsdata->hasManagedSave = tmp;
...so the input parser should reject the flag if it is inconsistent with
the domain state or specified at the same time as transient.
ACK with that fixed.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 621 bytes)