Re: [libvirt] [PATCH] libxl: fix memory corruption introduced by commit b55cc5f4e
Eric Blake wrote:
On 08/25/2014 05:01 PM, Jim Fehlig wrote:
> Commit b55cc5f4e did a shallow copy of libxl_{sdl,vnc}_info from the
> domain config to the build info, which resulted in double-freeing
> strings contained in the structures during cleanup, which later
> resulted in a libvirtd crash. Fix by performing a deep copy of the
> structure, VIR_STRDUP'ing embedded strings instead of simply copying
> their pointers.
>
> Fixes the following issue reported on the libvirt dev list
>
> https://www.redhat.com/archives/libvir-list/2014-August/msg01112.html
> Signed-off-by: Jim Fehlig <jfehlig(a)suse.com>
> ---
> src/libxl/libxl_conf.c | 22 ++++++++++++++++++----
> 1 file changed, 18 insertions(+), 4 deletions(-)
>
ACK.
Thanks; Pushed.
Regards,
Jim