Re: [libvirt] [PATCH v4 05/25] [NEW] qemu: remove superfluous setting of addrs->nbuses

18 Oct 2016

On Fri, 2016-10-14 at 15:54 -0400, Laine Stump wrote:
...
This is already set by virDomainPCIAddressSetAlloc().
---
 src/qemu/qemu_domain_address.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/qemu/qemu_domain_address.c b/src/qemu/qemu_domain_address.c
index d2a3237..3926b18 100644
--- a/src/qemu/qemu_domain_address.c
+++ b/src/qemu/qemu_domain_address.c
@@ -556,7 +556,6 @@ qemuDomainPCIAddressSetCreate(virDomainDefPtr def,
     if ((addrs = virDomainPCIAddressSetAlloc(nbuses)) == NULL)
         return NULL;
-    addrs->nbuses = nbuses;
     addrs->dryRun = dryRun;
/* As a safety measure, set default model='pci-root' for first pci
ACK

-- 
Andrea Bolognani / Red Hat / Virtualization

    