Re: [libvirt] [PATCH v3 10/17] qemu: Introduce label-size for NVDIMMs

On 03/09/2017 11:06 AM, Michal Privoznik wrote: Not that it matters in the grand scheme of things, but @access was split across 2 patches, while @label-size is all in one. The tests/qemuxml2xmloutdata/qemuxml2xmlout-memory-hotplug-nvdimm-label.xml has the same problem as patch 8 as make check fails for me... Required a similar adjustment from qemuxml2xmloutdata directory: ln -sf ../qemuxml2argvdata/qemuxml2argv-memory-hotplug-nvdimm-label.xml qemuxml2xmlout-memory-hotplug-nvdimm-label.xml FWIW: In re-reading my v2 review - not quite sure what was tripping me up about label-size. Perhaps when I saw that comparison to 128 I started overthinking things and missed the "if (def->labelsize..." Should there be a summary of what was written in: https://www.redhat.com/archives/libvir-list/2016-August/msg00650.html e.g. By default no Namespace Label area is reserved in the file. If the user specifies label-size then the memory at the end of the file is used as the Namespace Label area. For QEMU, there are two restrictions: 1. Minimum label size is 128K 2. Remaining size (total - labelsize) is aligned with 4k for nomral backend or hugepage-size for hugetblfs cannot be 0. (Or reworded sufficiently ;-)... Would be "nice" not lose that and something someone may trip across... ACK w/ the link fixed - bonus points for documentation adjustments. Better to do it now while it's still fresh in your mind rather than months down the road when someone asks and you're in the middle of something else! John [...] !!