Re: [libvirt] [V2 PATCH 0/3] Transport Open vSwitch per-port data during live migration

On 09/14/2012 03:01 PM, Kyle Mestery wrote: > This series of commits has the end goal of allowing per-port data stored > in the Open vSwitch DB to be transported during live migration. This is > done by first providing a generic infrastructure for transporting network > data, adding some utility functions specific to Open vSwitch, and hooking > the two together. > > The framework provided is generic in that other networking data could be > transferred as well by simply adding in additional hooks as needed. > ---- > V2 of this patch series fixes some issues found when migrating VMs on > standard Linux bridges. Oops. I just made some comments on one of the V1 patches before I scrolled down and saw these v2 patches. It looks like the same comments apply.

This is definitely looking better - it will make it much simpler for the next interface type that needs to send migration data to do so, and it gets the running of ovs-vsctl commands isolated into virnetdevopenvswitch.c. > > Kyle Mestery (3): > Add the ability for the Qemu V3 migration protocol to include > transporting network configuration. A generic framework is proposed > with this patch to allow for the transfer of opaque data. > Add utility functions for Open vSwitch to both save per-port data > before a live migration, and restore the per-port data after a > live migration. > Transport Open vSwitch per-port data during live migration by > using the utility functions virNetDevOpenvswitchGetMigrateData() > and virNetDevOpenvswitchSetMigrateData(). > > src/libvirt_private.syms | 2 + > src/qemu/qemu_migration.c | 291 +++++++++++++++++++++++++++++++++++++++- > src/util/virnetdevopenvswitch.c | 71 ++++++++++ > src/util/virnetdevopenvswitch.h | 6 + > 4 files changed, 368 insertions(+), 2 deletions(-)