Re: [Libvir] [PATCH] Add xen and hvm guest types to test drive caps

Daniel P. Berrange wrote: > On Tue, Mar 04, 2008 at 04:17:34PM -0500, Cole Robinson wrote: >> The attached patch adds xen and hvm guest types to the test driver's >> capabilities. It was currently set to offer only a 'linux' type which >> doesn't seem to follow the conventions of the other drivers, so I >> removed that. Please yell if I'm wrong :) > > THis patch all seems fine to me. The only problem you'll likely hit is > that the domain XML parser won't like the full-virt style <os> block > where you list a <boot> tag instead of kernel/initrd. Of course you can > do HVM + kernel/initrd too, so I've no problem adding this patch - just > that we'll likely need to add more XML parsing support to the test driver > to give full coverage of the HVM style configs. > >> @@ -984,6 +984,8 @@ static char *testGetCapabilities (virConnectPtr conn) >> char *xml; >> int cell1[] = { 0, 2, 4, 6, 8, 10, 12, 14 }; >> int cell2[] = { 1, 3, 5, 7, 9, 11, 13, 15 }; >> + const char *guest_types[] = { "hvm", "xen" }; >> + int num_guest_types = 2, i; > > Having a 'num_guest_types' variable is not neccessary... > >> + for (i = 0; i < num_guest_types; ++i) { > > Just use 'sizeof(guest_types)/sizeof(guest_types[0])' instead > > Regards, > Dan. I forgot to resend this :/