Re: [libvirt] [PATCH v3 1/3] qemu: Add capability for the HTM pSeries feature
On 06/26/2018 06:21 AM, Andrea Bolognani wrote:
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml | 1 +
tests/qemucapabilitiesdata/caps_3.0.0.ppc64.xml | 1 +
4 files changed, 5 insertions(+)
Weird to see having htm supported after the max page size - chicken and
egg type problem. I mean how do you have hpt without having max page
size. Anyway, just one of life's ironies I suppose. I would think just
having page size is enough, but what do I really know about pSeries, not
much ;-). If that's really not the case, well then fine separate caps it is.
Reviewed-by: John Ferlan <jferlan(a)redhat.com>
John
BTW: Although it is a bz, it's "debatable" if you're fixing a bug or
enabling a feature during freeze even though it was posted before
freeze, so this I believe should wait for 4.6 to open.