
13 Jul
2023
13 Jul
'23
2:13 p.m.
On Thu, Jul 13, 2023 at 4:05 PM Michal Privoznik <mprivozn@redhat.com> wrote:
If a domain has NUMA configured, then all <memory/> devices (except for 'virtio-pmem') need to have targetNode set. There are two checks inside of qemuDomainDefValidateMemoryHotplugDevice() for this: one inside of big switch() statement, which only checks 'dimm' and 'nvdimm' cases, and the other at the end of the function that checks all models (except for 'virtio-pmem'). Let's keep the latter and remove the former as the latter covers the former too.
Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- src/qemu/qemu_domain.c | 9 --------- 1 file changed, 9 deletions(-)
Reviewed-by: Kristina Hanicova <khanicov@redhat.com> Kristina