Re: [libvirt] [PATCH 10/14] Basic qemu NIC hotplug support
On Mon, 2009-07-20 at 17:31 +0100, Daniel P. Berrange wrote:
I'd recommend adding a nice VIR_DEBUG() line in after each
command, including
the reply string, so if something goes wrong we can debug it more easily.
Done.
On Mon, 2009-07-20 at 17:32 +0100, Daniel P. Berrange wrote:
On Mon, Jul 20, 2009 at 12:51:21PM +0100, Mark McLoughlin wrote:
> +try_remove:
> + reply = NULL;
> +
> + if (!remove_cmd)
> + VIR_WARN0(_("Unable to remove network backend\n"));
> + else if (qemudMonitorCommand(vm, remove_cmd, &reply) < 0)
> + VIR_WARN(_("Failed to remove network backend with
'%s'\n"), remove_cmd);
> +
> + VIR_FREE(reply);
> + VIR_FREE(remove_cmd);
> +
> + return -1;
> }
Should log the reply text too upon failure, since that's probably
more useful data
There's no reply text if qemudMonitorCommand() fails, but I've added a
debug log on success.
Cheers,
Mark.