On Thu, Nov 21, 2024 at 02:35:34PM +0100, Jiri Denemark wrote:
On Wed, Nov 20, 2024 at 12:11:19 +0000, Daniel P. Berrangé wrote:
On Tue, Nov 19, 2024 at 07:49:45PM +0100, Jiri Denemark wrote:
We already visually group the included models according to vendor using comments. This patch introduces a new <group> element for doing it properly in a machine friendly way.
AFAICT the <group> has no functional effect
If we're just going to group everything based on vendor, why not just call the tag <vendor name=...> ?
We can't use just vendor because some models (the old ones) don't have a vendor. We could perhaps use something like vendor='generic', vendor='QEMU' or something similar, although using the complete text from the comment makes reading a bit easier for people.
From QEMU's POV every model has a vendor. Looking at these: + <group name='generic'> + <include filename='x86_486.xml'/> + </group> This is an Intel model + + <group name='Intel-based QEMU generic CPU models'> + <include filename='x86_pentium.xml'/> + <include filename='x86_pentium2.xml'/> + <include filename='x86_pentium3.xml'/> + <include filename='x86_pentiumpro.xml'/> + <include filename='x86_coreduo.xml'/> + <include filename='x86_n270.xml'/> + <include filename='x86_core2duo.xml'/> + </group> and these are all intel models. I'd expect all of these to be under the main Intel vendor block. + + <group name='Generic QEMU CPU models'> + <include filename='x86_qemu32.xml'/> + <include filename='x86_kvm32.xml'/> + <include filename='x86_cpu64-rhel5.xml'/> + <include filename='x86_cpu64-rhel6.xml'/> + <include filename='x86_qemu64.xml'/> + <include filename='x86_kvm64.xml'/> + </group> These names don't directly correspond to a specific physical piece of silicon shipped by a vendor, but QEMU does tag them with a vendor internally, either intel or amd. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|