Re: [libvirt] [PATCH v2 02/19] docs: add master SVG for libvirt logo

On Tue, Nov 08, 2016 at 12:39:40PM +0000, Daniel P. Berrange wrote: > On Tue, Nov 08, 2016 at 01:32:54PM +0100, Martin Kletzander wrote: > > On Tue, Nov 08, 2016 at 11:50:13AM +0000, Daniel P. Berrange wrote: > > > Add the SVG files for the libvirt logo, along with corresponding > > > pre-rendered PNG bitmaps at key sizes. Also add a README file > > > describing how to modify the logos and their intended usages. > > > > > > Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com&gt; > > > --- > > > docs/Makefile.am | 27 +- > > > docs/logos/README | 86 ++++ > > > docs/logos/logo-banner-dark-256.png | Bin 0 -> 16093 bytes > > > docs/logos/logo-banner-dark-800.png | Bin 0 -> 64715 bytes > > > docs/logos/logo-banner-dark.svg | 655 +++++++++++++++++++++++++++++ > > > docs/logos/logo-banner-light-256.png | Bin 0 -> 16106 bytes > > > docs/logos/logo-banner-light-800.png | Bin 0 -> 64942 bytes > > > docs/logos/logo-banner-light.svg | 651 +++++++++++++++++++++++++++++ > > > docs/logos/logo-base.svg | 698 +++++++++++++++++++++++++++++++ > > > docs/logos/logo-square-128.png | Bin 0 -> 20074 bytes > > > docs/logos/logo-square-192.png | Bin 0 -> 38361 bytes > > > docs/logos/logo-square-256.png | Bin 0 -> 52107 bytes > > > docs/logos/logo-square-96.png | Bin 0 -> 13749 bytes > > > docs/logos/logo-square-powered-128.png | Bin 0 -> 21521 bytes > > > docs/logos/logo-square-powered-192.png | Bin 0 -> 41246 bytes > > > docs/logos/logo-square-powered-256.png | Bin 0 -> 55839 bytes > > > docs/logos/logo-square-powered-96.png | Bin 0 -> 14683 bytes > > > > I don't see the point in all these sizes. I would add one size, people > > can create bigger ones from the SVG (as described below) or smaller ones > > (either the same way or with scaling). Plus those that are used in > > docs/. I don't think we need that much redundant files in the git tree. > > Not a show stopper, though. > > The reason I created the multiple sizes is that actually creating the > PNG from the SVG is not entirely straightforward if you want a decent > quality result - inkscape export to PNG creates nasty fuzzy images, > and regular GIMP load from SVG creates badly scaled artifacts. > > What's in GIT gets copied around into other places like our the docbook > docs, wikipedia, google+, etc and I want to make sure people have good > quality PNGs to use and don't try to create their own and do a bad > job at it. > I get that, I know, it's described very nicely, I just wanted to express my feelings =) The files are not that big anyway. > > > > > diff --git a/docs/Makefile.am b/docs/Makefile.am > > > index fabae03..6eb5d3e 100644 > > > --- a/docs/Makefile.am > > > +++ b/docs/Makefile.am > > > @@ -365,6 +387,9 @@ uninstall-local: > > > for f in $(css) $(dot_html) $(gif) $(png); do \ > > > rm -f $(DESTDIR)$(HTML_DIR)/$$f; \ > > > done > > > + for f in $(logofiles); do \ > > > + rm -f $(DESTDIR)$(HTML_DIR)/$$f; \ > > > > s_/_/logos/ > > $f already inclues the 'logos/" dir prefix. > Then you need to remove that from install-data-local:, the previous hunk I deleted.