[libvirt PATCH 09/11] vircryptotest: Directly assign string to avoid memcpy
Found by clang-tidy's "bugprone-not-null-terminated-result" check.
clang-tidy's finding is a false positive in this case, as the
memset call guarantees null termination. The assignment can be
simplified though, and this happens to silence the warning.
Signed-off-by: Tim Wiederhake <twiederh(a)redhat.com>
---
tests/vircryptotest.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/tests/vircryptotest.c b/tests/vircryptotest.c
index 90140077cf..2c3d4bfe75 100644
--- a/tests/vircryptotest.c
+++ b/tests/vircryptotest.c
@@ -122,7 +122,7 @@ static int
mymain(void)
{
int ret = 0;
- uint8_t secretdata[8];
+ uint8_t secretdata[8] = "letmein";
uint8_t expected_ciphertext[16] = {0x48, 0x8e, 0x9, 0xb9,
0x6a, 0xa6, 0x24, 0x5f,
0x1b, 0x8c, 0x3f, 0x48,
@@ -166,9 +166,6 @@ mymain(void)
ret = -1; \
} while (0)
- memset(&secretdata, 0, 8);
- memcpy(&secretdata, "letmein", 7);
-
VIR_CRYPTO_ENCRYPT(VIR_CRYPTO_CIPHER_AES256CBC, "aes265cbc",
secretdata, 7, expected_ciphertext, 16);
--
2.26.2