Re: [Libvir] [PATCH] check the file name for --log

Atsushi SAKAI wrote:

Hi,

This patch fixes the trouble if execute virsh with virsh --log --debug. In this case FILE "--debug" is generated and --debug is off.

This patch treat as error return if it uses the hyphen "-" at the head of log file name.

+1 with reservations. I'm a bit surprised that getopt_long doesn't do the right thing here. With your patch we won't be able to have logfiles which begin with a '-' character. I'm not sure whether that's going to be a problem. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903