Re: [libvirt] [PATCH v3 4/7] qemu: Translate the iscsi pool/volume disk source
Il 23/07/2013 18:01, Daniel P. Berrange ha scritto:
On Tue, Jul 23, 2013 at 05:35:57PM +0200, Paolo Bonzini wrote:
> Il 23/07/2013 16:14, Daniel P. Berrange ha scritto:
>>>> Perhaps the default could be specified in a configuration file (and the
>>>> default should be the safe one).
>> No, that is even worse because now the default is not predictable..
>>
>> We simply default to host mode and if applications want to use the
>> other mode they can configure the XML as desired.
>
> Can we just forbid mode='default' for iSCSI and force the user to
> specify host vs. direct?
That would mean that apps cannot simply configure a guest volume
without first checking to find out what type of pool it is, and
then specifying this extra arg for iSCSI. IMHO the value of the
<volume> XML is that you don't have to know anything about the
pool to be able to configure it - we're completely decoupled.
Thinking more about it, it would only be needed for <disk type='volume'
device='lun'>. And for that case, some knowledge of the pool is
necessary anyway (for one thing, it won't work with filesystem or LVM
pools). So if we could forbid mode='default' for that case only, it
would be enough as far as I'm concernde.
Paolo