----- Original Message -----
Found by coverity: Error: SIZEOF_MISMATCH (CWE-569): libvirt-0.10.2/tools/virsh-domain.c:4754: suspicious_sizeof: Passing argument "8UL /* sizeof (cpumap) */" to function "_vshCalloc(vshControl *, size_t, size_t, char const *, int)" and then casting the return value to "unsigned char *" is suspicious.
Error: SIZEOF_MISMATCH (CWE-569): libvirt-0.10.2/tools/virsh-domain.c:4942: suspicious_sizeof: Passing argument "8UL /* sizeof (cpumap) */" to function "_vshCalloc(vshControl *, size_t, size_t, char const *, int)" and then casting the return value to "unsigned char *" is suspicious. --- tools/virsh-domain.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
ACK.
- cpumap = vshCalloc(ctl, cpumaplen, sizeof(cpumap)); + cpumap = vshCalloc(ctl, cpumaplen, sizeof(*cpumap));
Bugs like this show why we prefer VIR_ALLOC_N. Maybe we should fix vshCalloc to be a thin wrapper around VIR_ALLOC_N, but that's a bigger task for another day.