On Thu, Dec 27, 2018 at 01:20:44PM +0300, Nikolay Shirokovskiy wrote:
virDomainDiskSourceParse expects VIR_DOMAIN_DEF_PARSE_* values in @flags and we pass VIR_DOMAIN_SNAPSHOT_PARSE_* values. Fortunately sources of type 'file' and 'block' do not take flags into account and for source of type 'network' flags only make difference for tlsFromConfig atribute which is never passed I guess and never
"I guess" does not sound comforting. How about: which is only formatted for the status XML (with the VIR_DOMAIN_DEF_PARSE_STATUS flag), not the domain definition inside the snapshot XML, which uses VIR_DOMAIN_DEF_FORMAT_INACTIVE.
used.
Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com> --- src/conf/snapshot_conf.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
Reviewed-by: Ján Tomko <jtomko@redhat.com> Jano