On Thu, Jan 05, 2012 at 09:44:27AM +0100, Paolo Bonzini wrote:
Summary: two nits, one in the docs and one at the end of this email.
[Osier, I'm CCing you because there is some food for thought for SCSI].
On 01/05/2012 05:17 AM, Laine Stump wrote:
@@ -4241,6 +4273,7 @@ qemuBuildCommandLine(virConnectPtr conn, bootFloppy = 0; break; case VIR_DOMAIN_DISK_DEVICE_DISK: + case VIR_DOMAIN_DISK_DEVICE_LUN: bootindex = bootDisk; bootDisk = 0; break;
Suboptimal, because a type='lun' disk could well be a CD. :/ But short of supporting bootindex directly in the <disk> and <network> items, we cannot do much about it though.
We already support bootindex directly, via <boot order='N'/> <disk type='file' device='cdrom'> <source file='/root/boot.iso'/> <target dev='hdc' bus='ide'/> <boot order='1'/> <readonly/> <address type='drive' controller='0' bus='1' unit='0'/> </disk> <disk type='network' device='disk'> <driver name='qemu' type='raw'/> <source protocol='sheepdog' name='image'> <host name='example.org' port='6000'/> </source> <target dev='vda' bus='virtio'/> <boot order='3'/> </disk> <interface type='user'> <mac address='00:11:22:33:44:55'/> <model type='virtio'/> <boot order='2'/> </interface> Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|