Re: [libvirt] [PATCH 15/20] Provide missing passphrase when creating a volume.

----- "Daniel P. Berrange" <berrange(a)redhat.com&gt; wrote: > > + /* A qcow passphrase is up to 16 bytes, with any data following a NUL > > + ignored. Prohibit control and non-ASCII characters to avoid possible > > + unpleasant surprises with the qemu monitor input mechanism. */ > > + fd = open("/dev/urandom", O_RDONLY); > > + if (fd < 0) { > > + virStorageReportError(conn, VIR_ERR_INTERNAL_ERROR, "%s", > > + _("Cannot open /dev/urandom")); > > + goto cleanup; > > + } > > + i = 0; > > + while (i < sizeof (value)) { > > + ssize_t r; > > + > > + while ((r = read(fd, value + i, 1)) == -1 && errno == EINTR) > > + ; > > + if (r <= 0) { > > + virStorageReportError(conn, VIR_ERR_INTERNAL_ERROR, "%s", > > + _("Cannot read from /dev/urandom")); > > + goto cleanup; > > + } > > + if (value[i] >= 0x20 && value[i] <= 0x7E) > > + i++; /* Got an acceptable character */ > > + } > > + close(fd); > > I reckon this snippet of code could usefully be put into the util.h file > as virFileGenerateRandomkey(), or alternatively perhaps secret_conf.h, > as virSecretGenerateRandomKey(unsigned char *buf, size_t buflen); This code, with its limitation to ASCII characters, is qcow/qemu-specific.