On 01/11/2010 06:53 AM, Guido Günther wrote:
On Fri, Jan 08, 2010 at 11:50:17AM +0100, Daniel Veillard wrote:
Looks safe to me, assuming the kernel information are exported in the same way, Yes, it seems to be the same. Pushed now. Cheers, -- Guido
-- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
if (device == NULL) { VIR_ERROR("Failed to get udev device for syspath '%s'\n", DMI_DEVPATH); I don't think we want to log this message unless the device is not found either place. - goto out; + + device = udev_device_new_from_syspath(udev, DMI_DEVPATH_FALLBACK); + if (device == NULL) { + VIR_ERROR("Failed to get udev device for syspath '%s'\n", DMI_DEVPATH_FALLBACK); + goto out; + } } Dave