On Thu, Sep 14, 2017 at 04:45:30PM +0200, Andrea Bolognani wrote:
On Thu, 2017-09-14 at 14:48 +0100, Daniel P. Berrange wrote:
script: - - make -j3 && make -j3 syntax-check && make -j3 check + - make -j3 + - make -j3 syntax-check + - make -j3 check
# Environments here are run in addition to the main environment defined above matrix:
The downside of this is that if syntax-check fails, but check succeeeds, you now have to search through the middle of the logfile to find the failure, instead of just jumping straight to the end.
So I'm on the fence about this patch - I'd have a slight preference for existing behaviour of failing fast to keep errors at the end of the log
I can drop this patch and have the end result look like
script: # Many unit tests still fail on macOS, and there are a bunch of issues # with syntax-check as well, so skip them for now - make -j3 && if [ "$TRAVIS_OS_NAME" != "osx" ]; then make -j3 syntax-check && make -j3 check; fi
Would you like that better?
Yep, I think so Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|