On Wed, Oct 22, 2014 at 10:20:24PM -0600, Eric Blake wrote:
On 10/22/2014 11:14 AM, Daniel P. Berrange wrote:
Introduce a src/libvirt-network.c file to hold all the methods related to the virNetwork type. --- docs/apibuild.py | 1 + po/POTFILES.in | 1 + src/Makefile.am | 2 + src/libvirt-network.c | 1251 +++++++++++++++++++++++++++++++++++++++++++++++++ src/libvirt.c | 1221 ----------------------------------------------- 5 files changed, 1255 insertions(+), 1221 deletions(-) create mode 100644 src/libvirt-network.c
+++ b/src/libvirt-network.c
+ +VIR_LOG_INIT("libvirt.network"); + +#define VIR_FROM_THIS VIR_FROM_NONE +
Same comment as in 3/12 - do we want to update this to be more specific than VIR_FROM_NONE?
Yep, and consider the same change made for all other patches in this series.
Otherwise, I did the same review as mentioned in 2/12; it is just code motion.
ACK.
Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|