Hi, Dan Thank you for commenting. Of course, I agree your point and that you are commiting it. I am commenting it just because 2 month is not old ago in my feeling. Here Is the memo for my understanding. (Since I am not familiar with KVM) 2007/07/19 kvm-30 Guest SMP support (Parameter(KVM_MAX_VCPUS) changes from 1 to 4 in KVM-28) 2008/02/26 kvm-62 VCPUS changes 4 to 16 Thanks Atsushi SAKAI "Daniel P. Berrange" <berrange@redhat.com> wrote:
On Tue, May 13, 2008 at 01:29:35PM +0900, Atsushi SAKAI wrote:
Hi, Dan
I think the qemu_driver should check KVM_API_VERSION for SMP support. How do you think? I am worrying about MAX_VCPUS=16 changes to 32 in future.
If it increases to 32, then we should certainly check based on something like KVM_API_VERSION. I just don't think its worth checking for the ancient versions which only support 1 cpu because no one will be seriously using them.
Regards, Daniel. -- |: Red Hat, Engineering, Boston -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|