Re: [libvirt] [PATCH] examples: Add script to parse topology from capabilities output

On 09/02/2013 04:57 PM, Peter Krempa wrote: > Add a demo script originally written by Amador Pahim to parse topology > of the host from data provided in the capabilities XML. > --- > examples/python/topology.py | 45 +++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 45 insertions(+) > create mode 100755 examples/python/topology.py > > diff --git a/examples/python/topology.py b/examples/python/topology.py > new file mode 100755 > index 0000000..1b678bc > --- /dev/null > +++ b/examples/python/topology.py

> + > +print "Host topology" > +print "NUMA nodes:", cells.getAttribute('num') > +print " Sockets:",len(set(socketIds)) > +print " Cores:",len(set(siblingsIds)) > +print " Threads:",total_cpus > I won't get into details like len() vs. .length, string formatting, etc. ;-) But please add a space after these commas.

Even though I don't know how this will turn out on those weird multi-processor per core and similar architectures/processors, it should turn out OK since you're the one who should know how those will look in the capabilities XML. It would be also worth adding it into specfile like other python examples (I'm guessing those are in libvirt-python).

ACK with those two things fixed,

Martin