On Mon, Jan 20, 2014 at 12:27:29PM +0100, Thorsten Behrens wrote:
--- examples/object-events/event-test.c | 20 +++++------ src/conf/nwfilter_conf.c | 72 ++++++++++++++++++------------------- src/esx/esx_vi.c | 2 +- src/libvirt.c | 2 +- src/nwfilter/nwfilter_learnipaddr.c | 2 +- src/openvz/openvz_conf.c | 2 +- src/openvz/openvz_driver.c | 2 +- src/phyp/phyp_driver.c | 2 +- src/util/virlog.c | 4 +-- src/util/virsysinfo.c | 2 +- src/xen/xen_driver.c | 4 +-- src/xen/xs_internal.c | 10 +++--- src/xenapi/xenapi_driver.c | 22 ++++++------ tests/commandtest.c | 4 +-- tests/qemumonitorjsontest.c | 2 +- tools/virsh-domain.c | 6 ++-- tools/virsh-host.c | 2 +- tools/virt-login-shell.c | 2 +- 18 files changed, 81 insertions(+), 81 deletions(-)
[...]
diff --git a/src/openvz/openvz_conf.c b/src/openvz/openvz_conf.c index 91b16f8..b14e1d7 100644 --- a/src/openvz/openvz_conf.c +++ b/src/openvz/openvz_conf.c @@ -937,7 +937,7 @@ static char * openvzLocateConfDir(void) { const char *conf_dir_list[] = {"/etc/vz/conf", "/usr/local/etc/conf", NULL}; - int i=0; + int i = 0;
Thanks to this fix, there is another problem making this fail due to 'i' not being size_t. Also s/whitespace/shitespaces/ in $SUBJ. Other than that the patch looks fine, but as I mentioned in the first patch, in order not to break future bisecting, these patches should be applied in reverse order (first fix those problems and then make the syntax-check check them). I fixed mentioned things and pushed. Thank you and congratulations to your first patches in libvirt! Have a nice day, Martin