On Tue, Mar 06, 2018 at 09:43:15AM -0500, Laine Stump wrote:
On 03/06/2018 07:44 AM, Daniel P. Berrangé wrote:
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- Changes | 2 +- lib/Sys/Virt.pm | 32 ++++++++++++++++++++++++++++++++ 2 files changed, 33 insertions(+), 1 deletion(-)
diff --git a/Changes b/Changes index f560864..d2d9a94 100644 --- a/Changes +++ b/Changes @@ -2,7 +2,7 @@ Revision history for perl module Sys::Virt
4.2.0 2018-00-00
- - XXX + - Add missing define_nwfilter and define_secret APIs in Sys::Virt
4.1.0 2018-03-05
diff --git a/lib/Sys/Virt.pm b/lib/Sys/Virt.pm index 035cdb6..f93d122 100644 --- a/lib/Sys/Virt.pm +++ b/lib/Sys/Virt.pm @@ -315,6 +315,38 @@ sub define_network { return Sys::Virt::Network->_new(connection => $self, xml => $xml, nocreate => 1); }
+=item my $dom = $vmm->define_nwfilter($xml);
I noticed this about the documentation in a lot of places - it uses "$vmm" when I would have thought that "$conn" would be more plausible (i.e. a better implication of what kind of object it was supposed to be), and "$dom" when $[something else] would be better, e.g. $net, $nwfilter, etc.
Yeah, I don't really recall why i called this "vmm" anymore - so long ago now. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|