Re: [libvirt] [PATCH] Fix copy&paste typos in virProcessInfoGetAffinity
> +++ b/src/util/processinfo.c
> @@ -130,31 +130,31 @@ realloc:
^^^^^^^^
Is there a policy on indentation of labels? By default, emacs starts
labels in column 2, so that utilities that expect only function names to
appear in column 1 behave in a more predictable manner. I'm not sure
what indent(1) does in this case. At any rate, the git hunk header
detection regexp is an example of an external tool that expects to find
only function names on column 1, and which is being thrown off by the
presence of an intermediate label also in that column.
That looks like something which should be fixed in git.
> virReportSystemError(errno,
> - _("cannot set CPU affinity on process %d"),
pid);
> + _("cannot get CPU affinity of process %d"),
pid);
ACK.
Pushed, thanks.
Jirka