Re: [libvirt] [PATCH 8/9] qemuBuildHostNetStr: Support VIR_DOMAIN_NET_TYPE_VHOSTUSER
On 08/16/2016 11:41 AM, Michal Privoznik wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1366505
So far, this function lacked support for
VIR_DOMAIN_NET_TYPE_VHOSTUSER leaving callers to hack around the
problem by constructing the command line on their own. This is
not ideal as it blocks hot plug support.
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
---
src/qemu/qemu_command.c | 43 +++++++++++++---------
.../qemuxml2argv-net-vhostuser-multiq.args | 6 +--
.../qemuxml2argv-net-vhostuser.args | 4 +-
3 files changed, 31 insertions(+), 22 deletions(-)
Seems reasonable and at least the NULL parameters being sent are checked
in qemuBuildHostNetStr before being used.
ACK
John