[libvirt] Re: [PATCH] Add huge page support to libvirt, v2..
On Thu, Jul 23, 2009 at 09:00:18PM -0400, john cooper wrote:
I've incorporated feedback received on the
prior version into the patch below.
The host mount point for hugetlbfs is queried by
default from /proc/mounts unless overridden in
qemu.conf via:
hugepage_mount = "<path_to_mount_point>"
This should make the concern of establishing
a mount point path convention a non-issue for
the general case while still allowing the same
to be deterministically set if needed.
In light of what Chris said about extended attribute support
for SELinux I think we, sadly, have no choice by to mount
a new instance of hugetlbfs per VM, labelled with the context
of that VM. The problem is that this doesn't really fit into
the internal architecture we have in the slightest. The
SELinux support we have is focused around re-labelling
existing resources.
This hugetlbfs support implies that the SELinux driver is
altering our command line arg generator, which is not an
easy thing for us to support, given the code flow here.
We might have to resort to sick gross hacks.... unless the
kernel guys think its easy to add extended attribute support
to hugetlbfs in no time at all.
Complete disable of hugepage backing can be
accomplished by setting the mount point to "".
A guest now requests hugepage backing via
specifying:
<hugepage enable='on'/>
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|