On Fri, Feb 22, 2019 at 11:42:04AM +0300, David Kiarie wrote:
> On Fri, Feb 22, 2019 at 11:09 AM Jiri Denemark <jdenemar@redhat.com> wrote:
>
> > On Fri, Feb 22, 2019 at 08:50:55 +0100, Peter Krempa wrote:
> > > On Thu, Feb 21, 2019 at 21:44:34 +0300, David Kiarie wrote:
> > > > it looks sensible that the copyright notice on the affected files in
> > > > updated as in this patch so as to also cover another party who hugely
> > > > participated in writing the code.
> > >
> > > I must point out that you specifically asked us to remove your name
> > > from the files:
> > >
> > > https://www.redhat.com/archives/libvir-list/2018-May/msg00382.html
> > >
> > > Which was fulfilled after the discussion in the thread above by:
> > >
> > > https://www.redhat.com/archives/libvir-list/2018-May/msg00483.html
> > >
> > > And now lives in the repo as:
> > >
> > > commit d894e49292ae5135b6a9f44a634b5cfca4376f19
> > > Author: David Kiarie <davidkiarie4@gmail.com>
> > > Date: Tue May 8 15:40:00 2018 +0300
> > >
> > > xenconfig: remove my name and email from files
> > >
> > >
> > > Did you change your mind?
> >
>
> yes, i will actually share the copyright, if possible.
Note that you already own the copyright on any code you contributed,
regardless of whether any Copyright line exists in the files. The only
way you loose coyright ownership is by explicitly assigning it to
another person / organization. This is why the majority of patches
never bother to add any copyright lines.
the copyright notice you have on these files, especially the file xen_xl.c does not respect other parties who participated in the writing the code.
> i think an email is personal enough that it shouldn't appear on copyright
> notice just like i can't have my phone number on the copyright declaration.
Your email is public regardless because every mail on this mailing list
is public, and every git commit to libvirt is public, and every release
of libvirt contains a AUTHORS file which includes every name + email
address. IOW your email address in the source header makes no difference,
it is already widely publicised.
i do not want my email on the source header as someone grabbed it elsewhere and it didn't end well.
i'd rather someone digs into the commits if they want my email, next time not just finds an issue in a file, quickly grabs the email and directs the complain to me.
Regards,
Daniel